Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved sui::framework_versions to sui_package_management::system_package_version #21189

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

mdgeorge4153
Copy link
Contributor

Description

This PR does some reshuffling and renaming of the recently added sui::framework_versions module:

  • It is moved lower in the crate stack, so that sui-move-build can depend on it.
  • I renamed "framework" to "system_packages" in various places, since technically there are more system packages than just the framework and this maybe led to some confusion

Test plan

Updated existing tests


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Feb 12, 2025 1:55pm
sui-kiosk ⬜️ Ignored (Inspect) Feb 12, 2025 1:55pm

@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 12, 2025 13:55 — with GitHub Actions Inactive
Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdgeorge4153

@mdgeorge4153 mdgeorge4153 merged commit 2fc6c99 into main Feb 15, 2025
47 checks passed
@mdgeorge4153 mdgeorge4153 deleted the mdgeorge/framework-version-move branch February 15, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants